coreybutler / nvm-windows

A node.js version management utility for Windows. Ironically written in Go.
MIT License
37.28k stars 3.32k forks source link

Show terminal warning only when user did not enter arguments. #1120

Open johnrom opened 6 months ago

johnrom commented 6 months ago

closes #1068

(doesn't fix the underlying terminal check, but limits the issue to users who didn't enter any nvm command)

Only check terminal when there are no arguments, because it's possible the user clicked the .exe. If there are arguments, assume the user knows what they're doing. Add some launch tasks in .vscode to demonstrate the difference. The warning now indicates that if you are in an unsupported terminal, to try running nvm help instead.

Feel free to remove .vscode/launch.json if you do not use VS Code. I used it to create an example of:

github-actions[bot] commented 5 months ago

This PR is stale because it has been open 45 days with no activity.

github-actions[bot] commented 4 months ago

This PR is stale because it has been open 45 days with no activity.

mpociot commented 3 months ago

Would be great if this could get reviewed and merged 👍

github-actions[bot] commented 2 months ago

This PR is stale because it has been open 45 days with no activity.

EmilSoleymani commented 2 months ago

Can this be reviewed/merged? Currently blocking my Jenkins2 pipelines

github-actions[bot] commented 1 month ago

This PR is stale because it has been open 45 days with no activity.