Open johnrom opened 6 months ago
This PR is stale because it has been open 45 days with no activity.
This PR is stale because it has been open 45 days with no activity.
Would be great if this could get reviewed and merged 👍
This PR is stale because it has been open 45 days with no activity.
Can this be reviewed/merged? Currently blocking my Jenkins2 pipelines
This PR is stale because it has been open 45 days with no activity.
closes #1068
(doesn't fix the underlying terminal check, but limits the issue to users who didn't enter any
nvm
command)Only check terminal when there are no arguments, because it's possible the user clicked the
.exe
. If there are arguments, assume the user knows what they're doing. Add some launch tasks in.vscode
to demonstrate the difference. The warning now indicates that if you are in an unsupported terminal, to try runningnvm help
instead.Feel free to remove
.vscode/launch.json
if you do not use VS Code. I used it to create an example of:nvm
without commands in debug console -- opens warning indicatingnvm
can only be run in a terminalnvm
in external console (like command prompt) -- prints normal help message in terminalnvm version
in debug console -- works normally