search

coreybutler / nvm-windows

A node.js version management utility for Windows. Ironically written in Go.
MIT License
37.28k stars 3.32k forks source link

Add support for mklink with junctions #1139

Closed mklemarczyk closed 4 months ago

mklemarczyk commented 4 months ago

Additional mode of work with support for NTFS junction points. It allows user to create link between directories when permission to create directory symlinks is denied. Fixes bug #79

To enable the option simply put the configuration in your nvm settings.txt. (option is disabled by default to keep the compatibility.

symlink_junction: true

Please review well the PR, it is my first time with golang ;) Developed with golang 1.22.3 in mind. Tested and verified on the restricted machine. 🆗 Tested and verified on the unrestricted machine. 🆗

coreybutler commented 4 months ago

While I appreciate the effort, see my comments on the issues related to junctions. I really hate turning away a PR and the passion you've shown for this feature and the project as a whole. I truly, truly appreciate that.

mklemarczyk commented 3 months ago

I will create own fork than and release there.