coreylowman / cudarc

Safe rust wrapper around CUDA toolkit
Apache License 2.0
603 stars 74 forks source link

Remove dependency on find_cuda_helper #91

Closed coreylowman closed 1 year ago

coreylowman commented 1 year ago

To reduce dependencies

M1ngXU commented 1 year ago

is it really necessary? isn't the dep small anyway?

coreylowman commented 1 year ago

It's a small one, but every dependency adds up. We can see how much time it actually saves by removing it.

I'd also like to fix and issue that I have every time I use GPUs on cloud.lambdalabs, which is I need to run

sudo ln -s /usr/lib/cuda /usr/local/cuda

for find_cuda_helper to find it.

M1ngXU commented 1 year ago

Ah ok, makes sense. Didn't know that such a small dependency adds that much compile time 😅

quietlychris commented 1 year ago

I believe I ran into the same issue with find_cuda_helper as well on a Pop!_OS installation (basically Ubuntu) regarding the cuda path not being one of the defaults in that crate anyway, which took a bit minute to track down.