coreylowman / dfdx

Deep learning in Rust, with shape checked tensors and neural networks
Other
1.71k stars 99 forks source link

Split `TryConcatAlong` into different traits #892

Closed swfsql closed 10 months ago

swfsql commented 10 months ago

Closes #891.

The added test, that initially failed to compile: https://github.com/coreylowman/dfdx/blob/b2922541241ea2aaa1cd128132afc9f3005bb4a4/dfdx/tests/issue_tests.rs#L4-L44

coreylowman commented 10 months ago

@swfsql looks good - do you mind merging with the webgpu changes I just merged? Should be pretty straightforward 🤞 No need to test with webgpu features yet

swfsql commented 10 months ago

@coreylowman sure np, I've rebased and basically just moved the webgpu kernel to where the others are.

I've made one change, remaking this item as public so it's the same behavior as from before. https://github.com/coreylowman/dfdx/blob/2a31bdfe5a4fafe46d0766cfa686a02a5aaba0a3/dfdx-core/src/tensor_ops/concat_along/mod.rs#L1

coreylowman commented 10 months ago

Woohoo, thanks for this change! 🎉