Closed swfsql closed 10 months ago
@swfsql looks good - do you mind merging with the webgpu changes I just merged? Should be pretty straightforward 🤞 No need to test with webgpu features yet
@coreylowman sure np, I've rebased and basically just moved the webgpu kernel to where the others are.
I've made one change, remaking this item as public so it's the same behavior as from before. https://github.com/coreylowman/dfdx/blob/2a31bdfe5a4fafe46d0766cfa686a02a5aaba0a3/dfdx-core/src/tensor_ops/concat_along/mod.rs#L1
Woohoo, thanks for this change! 🎉
Closes #891.
dfdx_core
. But there's no Module indfdx::nn
representing tensor concatenation, so I've added as an integration test.TryConcatAlong
in favor ofTryConcatTensorAlong
orTryConcatShapeAlong
.concat_tensor_along/
andconcat_shape_along/
.concat_along
, adjusting where necessary.concat_along/
kernels toconcat_tensor_along/
.The added test, that initially failed to compile: https://github.com/coreylowman/dfdx/blob/b2922541241ea2aaa1cd128132afc9f3005bb4a4/dfdx/tests/issue_tests.rs#L4-L44