search

coreymckrill / nearby-wordpress-events

A widget to show nearby WP events in the Dashboard
GNU General Public License v2.0
11 stars 4 forks source link

a11y: don't use placeholders as replacement for labels #33

Closed afercia closed 7 years ago

afercia commented 7 years ago

See also https://core.trac.wordpress.org/ticket/40331

For accessibility, placeholder attributes should not be used as replacements for labels. It's far better to display a visible label and remove the placeholder:

screen shot 2017-04-17 at 17 16 12
iandunn commented 7 years ago

Great point.

@mapk, how do you feel about us adding a City: label to the left of the input field, and then changing the placeholder to something like Vancouver, Toronto, Quebec? (The specific cities would be set by translators, and we would ask them to pick cities in their locale and write them in that locale's language).

mapk commented 7 years ago

Good idea. Let's do it.