search

coreytegeler / add-art-chrome

http://add-art.org
34 stars 10 forks source link

Preferences interface #11

Open slambert opened 9 years ago

slambert commented 9 years ago

It'd be nice to include some of the preferences that uBlock has for adding elements to block, etc.

slambert commented 8 years ago

Doing some testing with it and noticing a few ads that get through – as I scroll down on http://www.nytimes.com/ for example. I'm not even sure how it's working now 😀 but it would be nice to be able to, as a user, add items to block in the future. Or maybe subscribe to these? https://easylist.adblockplus.org/en/

UPDATE: Now I'm thinking those ads that don't change aren't getting caught because of a lazy-load type thing. They load as you scroll down. I noticed one switch, but others didn't.

owise1 commented 8 years ago

I think you're right that it's the lazy loading that's slipping them by. I can test a bit, but I'm not sure the extension script is always being triggered by the lazy-loaded ads.

As to how it works now, it's pretty straightforward now, which is nice. This line https://github.com/coreytegeler/add-art-chrome/blob/master/js/document_end.js#L5 is trying to find the ads on the page. That script runs every time a document is loaded, like every time an iframe loads within the page.

slambert commented 8 years ago

Hm, so instead of that line in the code, could it check a file? Then you could have some defaults loaded in (like you have) and add others? I think if, somehow, you could use that easylist format, you'd block almost everything that most people find annoying and they could tailor it for their country/language.

I was thinking about this and YouTube. AdBlockPlus blocks youtube ads, and whenever I use another computer, I find YouTube intolerable (I'm spoiled). So it would be great if Add-Art could block (and replace where possible) most ads, because we will be competing with adblockers. If the experience should be at least as good, and hopefully better, than an adblocker. Know what I mean?

owise1 commented 8 years ago

Yeah, it could totally check a file like that.

To your second point, as far as I can tell, the main way that current ad block plugins prevent ads is by blocking requests to ad services, not by removing ads. The ads never make it to the page. uBlock, for example, does have some code attempting to clean up ads that might make it through, but it probably doesn't get much use, because my single line of code does way better than it at catching ads. Blocking requests seems like a much more effective way of doing it. I'm not sure we can "compete" because we need to allow the ads to be created (usually asynchronously via javascript) in order to replace them. So it's a matter of periodically checking the page for ad-like elements.

We also can't compete with those extensions on the issue of privacy. Blocking requests at the browser level prevents the ad services from tracking the user. But again we need the ads to be created in order to replace them.

Maybe there's a better approach altogether. One where you can still have an extension like uBlock or AdBlockPlus blocking ads, but then you create art ads where they might have been. Just thinking out loud...

On Fri, Jan 29, 2016 at 7:48 AM, Steve Lambert notifications@github.com wrote:

Hm, so instead of that line in the code, could it check a file? Then you could have some defaults loaded in (like you have) and add others? I think if, somehow, you could use that easylist format, you'd block almost everything that most people find annoying and they could tailor it for their country/language.

I was thinking about this and YouTube. AdBlockPlus blocks youtube ads, and whenever I use another computer, I find YouTube intolerable (I'm spoiled). So it would be great if Add-Art could block (and replace where possible) most ads, because we will be competing with adblockers. If the experience should be at least as good, and hopefully better, than an adblocker. Know what I mean?

— Reply to this email directly or view it on GitHub https://github.com/coreytegeler/add-art-chrome/issues/11#issuecomment-176828682 .

(()liver \/\/ise

slambert commented 8 years ago

If we use that subscription list, we might miss fewer ads...

Re: privacy - AdNauseum has made a good case for clicking on everything instead of hiding, which is why we should talk with @dhowe and @mushon, but I'm not to worried about that. I just don't want to watch youtube ads and stuff.

Your last paragraph kinda describes how it used to work! But no looking back, right!?

owise1 commented 8 years ago

It looks like you can use add-art and ad block plus simultaneously. That way you get the best of both worlds. For example: http://www.walmart.com/ still shows art ads. But AdBlockPlus is blocking the script based ads on http://www.nytimes.com/ so there's nothing to replace.

I think you could try to find the ad script tags and then just create an art ad in that space :). i'll create an issue for this

slambert commented 8 years ago

Sounds good. I think I'm probably in the minority of users who think and care about this stuff, but we can address "how do I block video ads?" "does add-art play well with X?" and "what about privacy?" type questions on the site.