search

coreytegeler / add-art-chrome

http://add-art.org
34 stars 10 forks source link

Wondering if uBlock is even necessary / overkill #14

Closed owise1 closed 8 years ago

owise1 commented 8 years ago

uBlock is primarily concerned with blocking requests to known advertisers, but as a secondary feature, it also tries to hide ads that make it through. We're disabling it's primary function and then it's not really hiding that many ads via it's backup system. I caught more ads by simply searching the page for google ad iframes.

a pro would be that it would make the code a lot more straightforward and eliminate an unwieldy dependency. a con would be needing to spend some time tracking down ways to identify ads

owise1 commented 8 years ago

hmm, this actually works just as well as far as I can tell: https://github.com/coreytegeler/add-art-chrome/tree/noublock

owise1 commented 8 years ago

uh yeah, this works just as well and is so much simpler! removed uBlock