corin8823 / Popover

Popover is a balloon library like Facebook app. It is written in pure swift.
MIT License
2.09k stars 326 forks source link

Additional setting, that enables the popover to automatically avoid bottom screen edge #105

Closed vitalii-tym closed 6 years ago

vitalii-tym commented 6 years ago

There is a 3rd setting for popoverType now. Choosing it will make popover attempt to select proper type, .up or .down, depending on how much room there is left to the bottom screen edge. Defaults to .down if anything goes wrong.

Usage: popover.popoverType = .auto

The default type (which is .down at the moment) was not changed, because this new .auto option might probably need better testing on different orientations.

corin8823 commented 6 years ago

Thank you for reflecting. This is a wonderful job 👍