search

corin8823 / Popover

Popover is a balloon library like Facebook app. It is written in pure swift.
MIT License
2.09k stars 326 forks source link

This is supposed to fix broken corner in case it is very close to an edge (for .down direction only) #133

Closed vitalii-tym closed 4 years ago

vitalii-tym commented 4 years ago

The corner used to be corrected in case it its point is exactly at an edge, but in case the corner is not at the edge there was some visual cut-out. Not sure, but probably it is also mentioned in the issue #33

How it used to be:

Screenshot 2019-11-04 17 09 42

After fix:

Screenshot 2019-11-04 17 10 41
vitalii-tym commented 4 years ago

Please, don't accept it yet. Found some artifacts, will try to fix them.

vitalii-tym commented 4 years ago

Fixed some artifacts and covered the case when target view is behind the corner. Was after my first commit (artifacts appearing when opened from some specific positions):

Screenshot 2019-11-12 13 45 51

Fixed:

Screenshot 2019-11-12 17 05 44 Screenshot 2019-11-12 17 06 00

The change is only applicable for .down direction. Haven't had enough time to cover other directions.

corin8823 commented 4 years ago

I'm sorry to be late. Good Job!