corin8823 / Popover

Popover is a balloon library like Facebook app. It is written in pure swift.
MIT License
2.11k stars 327 forks source link

fix issue that can't popover twice with the same popover instance. #47

Closed lvdaqian closed 8 years ago

lvdaqian commented 8 years ago

I have met the issue #25. And found that it didn't reset the transform of Popover view when call dismiss.

It will cause Popover view can't be shown second time. Because the frame of Popover view is calculated wrong.

I use Xcode is 8.0 (8A218a) with Cocoapods 1.1.0 under swift 2.3

But I think the framework should support show popover again from the same instance.

lvdaqian commented 8 years ago

It failed because of using xcode 7.3.1 which is not support swift 3.

corin8823 commented 8 years ago

Thanks. nice work!