corin8823 / Popover

Popover is a balloon library like Facebook app. It is written in pure swift.
MIT License
2.11k stars 327 forks source link

Not Working in iOS 11 #88

Closed sudeep23 closed 7 years ago

sudeep23 commented 7 years ago

Popover works till iOS 10 but it doesn't pop up at all in iOS 11.

kramsretep commented 7 years ago

I'm seeing the same thing. One additional detail: it does popup if an input field on the same view is the first responder (and hence the keyboard is showing).

corin8823 commented 7 years ago

Sorry for replying late. Example works, but how does it work?

khantthulinn commented 7 years ago

yes. same. will you guys fix soon? if not, I gona need to find another library since our app launch is very near to support ios 11. Or is there any temp workaround?

khantthulinn commented 7 years ago

I found workaround. I just show like this. I need to specify inView.

        let window = UIApplication.shared.keyWindow!
        self.popover.show(tableView, fromView: fromView, inView: window)
chonex143 commented 7 years ago

Any update?

VatsalDev commented 7 years ago

Replace this method open func show(_ contentView: UIView, fromView: UIView) { guard let rootView = UIApplication.shared.windows.last ?? UIApplication.shared.keyWindow else { return } self.show(contentView, fromView: fromView, inView: rootView) }

with below method open func show(_ contentView: UIView, fromView: UIView) { guard let rootView = UIApplication.shared.keyWindow ?? UIApplication.shared.windows.last else { return } self.show(contentView, fromView: fromView, inView: rootView) }

CristianCardosoA commented 7 years ago

That method works fine. open func show(_ contentView: UIView, fromView: UIView) { guard let rootView = UIApplication.shared.keyWindow ?? UIApplication.shared.windows.last else { return } self.show(contentView, fromView: fromView, inView: rootView) }

paulshapiro commented 7 years ago

imho there should probably be an error log, fatalError, exception raised, or assert(false) on the guarded return for visibility

CristianCardosoA commented 7 years ago

Update your cocoa pod file. @paulshapiro

ghost commented 7 years ago

Fixed in #80 & tested on iOS 11.1 beta 5; this issue can be closed @corin8823

corin8823 commented 7 years ago

thanks 🤓 @vrwim-bazookas