corincerami / mars-photo-api

A Rails API for photo data from NASA's Mars Rovers
https://api.nasa.gov/#MarsPhotos
GNU General Public License v3.0
346 stars 46 forks source link

Permit :rover_id in photos controller #140

Closed mtilda closed 3 years ago

mtilda commented 3 years ago

I notice when I run a development version of the API, the console outputs Unpermitted parameter: :rover_id when I make a simple request like GET localhost:3000/api/v1/rovers/curiosity/photos?sol=10 via Insomnia. The request successfully serves the data with a status 200, but the red text in my console is concerning. It goes away when I permit :rover_id in photos_controller.rb

Are others experiencing this as well, or is this isolated to me?

corincerami commented 3 years ago

Thanks, this was resolved by your PR.