corincerami / mars-photo-api

A Rails API for photo data from NASA's Mars Rovers
https://api.nasa.gov/#MarsPhotos
GNU General Public License v3.0
352 stars 48 forks source link

request: remove restriction of 25 rows for certain API calls #26

Closed open768 closed 7 years ago

open768 commented 8 years ago

Hello the restriction to 25 rows returned could be a problem when querying a sol. For example if an application wanted to show the thumbnails for sol 42, which contains 2831 photos it would have to make 114 api calls within a very short period of time to get information about the photos available.

This could

instead it would be useful instead to return the manifest that gave summary details about all the photos available in the sol ie

{ "sol": 42, images:[ {"instrument": "FHAZ_RIGHT_B, "itemName": "FRB_504551158EDRT0520004FHAZ00323M"}, {...}, ... ] }

corincerami commented 8 years ago

@open768 I'll look into this when I get a chance to work on it. I think I can probably remove the limit from the API without causing too much of a performance problem. The pagination is really a relic of when this app had views instead of being a raw API and should have been removed.

open768 commented 8 years ago

Thanks. Dont worry too much about me, the json api I was using is back and seems to be supported by NASA so I'll continue using it.   My application is http://www.mars-browser.co.uk/curiosity/ and exposes its own restful APIs that transform and cache data from the following data sources without needing a relational database. These are the sources I use

corincerami commented 7 years ago

This pagination has been removed from the V1 API endpoint.