Upgrade from GTK2 to GTK3

corinfinite commented 7 years ago

Preparation steps done in 0ed157db0a675b2ab25da4e9bb347669535ef0de and 92f2ae34bd5f6962561e2ae22150c90e0552e109

Any checked items without a bullet point below them were not used/applicable

[x] Replace size_request by get_preferred_width/height
[x] Replace GdkRegion by cairo_region_t
[x] Replace GdkPixmap by cairo surfaces
Removed in 92f2ae34bd5f6962561e2ae22150c90e0552e109
Removed commented out code involving Pixmaps
[x] Replace GdkColormap by GdkVisual
[x] GdkDrawable is gone
[x] Event filtering
[x] Backend-specific code
[x] GtkPlug and GtkSocket
[x] The GtkWidget::draw signal
[x] GtkProgressBar orientation
[x] Check your expand and fill flags
[x] Scrolling changes
[x] GtkObject is gone
Unsure exactly how to resolve, for the time being changing GTK_OBJECT to G_OBJECT
[x] GtkEntryCompletion signal parameters
[x] Resize grips
[x] Prevent mixed linkage
It may be an issues that the latest gtkdatabox release (0.9.3.0) uses gtk2 and the release suggested in our current readme is 0.9.2.0
The master branch on the sourceforge repo advertises gtk3 support
This github repo advertises gtk3 support
It appears there may be gtk3 versions in newer Ubuntu repositories: https://packages.ubuntu.com/zesty/libgtkdatabox-0.9.3-0-glade
Further investigation is needed
[x] Install GTK+ modules in the right place

corinfinite commented 7 years ago

As of cac83894eb6319f24db7b2ca6ea174a932e8de67 BRP-PACU is using GTK3. There are several depreciated items that are causing issues.

[ ] The README must be updated to include instructions on how to install gtkdatabox that is compatible with gtk3.
[ ] All Mac related functionality is fundamentally broken. A note should be made in the README and it may be worth removing all Mac related code and starting from scratch since GTK3 provides cross platform support.

corinfinite commented 7 years ago

3f2bc41dae8b6a9d939f9e68ee1a053c2c8d14d0 deals with traces not displaying with the gtk3 compatible gtkdatabox.

Only outstanding work I see now is fixing buttons and squashing warnings.

corinfinite / brp-pacu