search

corlab / rst-rt

Real-time Robot Control Types
GNU General Public License v3.0
0 stars 2 forks source link

Use eigen-vectors when possible #11

Open ndehio opened 7 years ago

ndehio commented 7 years ago

The following types are based on eigen-matrices, however we should use eigen-vectors instead:

Pouya-moh commented 7 years ago

While this could help with readability, conceptually it is exactly the same:

typedef Matrix< float, 3, 1 >        Eigen::Vector3f
typedef Matrix< float, Dynamic, 1 >  Eigen::VectorXf

To me it is a bit of a not-so-necessary-refactoring-effort.

xwavex commented 7 years ago

partly ive already refactored this; but pouya is of course totally right.

Pouya notifications@github.com schrieb am Mo., 3. Apr. 2017, 11:05:

While this could help with readability, conceptually it is exactly the same:

typedef Matrix< float, 3, 1 > Eigen::Vector3ftypedef Matrix< float, Dynamic, 1 > Eigen::VectorXf

To me it is a bit of a not-so-necessary-refactoring-effort.

— You are receiving this because you were assigned.

Reply to this email directly, view it on GitHub https://github.com/corlab/rst-rt/issues/11#issuecomment-291087873, or mute the thread https://github.com/notifications/unsubscribe-auth/AHenuFwB6KQP9AShnLik1aQJzfT013K6ks5rsLZwgaJpZM4LesCY .