search

corley / aws-ant-task

Ant task implementation for Amazon Web Services
MIT License
16 stars 14 forks source link

Some refactoring made, mostly on S3 upload side. #1

Closed stoiczek closed 12 years ago

stoiczek commented 12 years ago

Hi,

I've allowed myself to fork your aws-ant-task repository. I needed ant tasks for uploading a chrome and Firefox extensions to S3. The problem though is that S3 doesn't recognize the FF add-on's content type, thus makes it almost impossible to install. All these changes are covered with integration tests (didn't had time to implement proper unit tests)

I've added new property to the S3 task (Renamed to S3PutTask) - contentType, and defined new type - ContentTypeMapping, which allows to map between file extension and content-type (useful when uploading in a batch).

I've also changed the build system to maven and removed all binary dependencies from the project source root.

And some minors - comments; removed the fail property. Hope you find it useful.

Additionally, if possible, please define a license under which you're releasing your lib.

Best regards, Ted

wdalmut commented 12 years ago

Hi,

Thanks for opening this pull request. I review it's content tomorrow but I think it's ok.

I attach a MIT license to this project.

Regards.