cormacmchale / ProfPractice

An ionic App
0 stars 0 forks source link

Code and App View clean-up #13

Closed cormacmchale closed 5 years ago

cormacmchale commented 5 years ago

I think before any project is complete a full run through of the code to tidy it up for maintainability.. I will document any major changes made just as future reference to help avoid any mistakes.

cormacmchale commented 5 years ago

First deleting test-geolocation page and was only used for practicing the with the Geolocation plugin.

Capture

cormacmchale commented 5 years ago

The next step would have been to rename the database page as 'manageJournies' however it is a bad idea as too many dependencies are created when you create a page in ionic. Will leave this as it is and learn from this mistake Capture

cormacmchale commented 5 years ago

Just basic commenting added to the app.module and app.component explaining the sidebar menu.

cormacmchale commented 5 years ago

Add a Journey CSS fixed, Using ion-grid to align the buttons properly below the search bar Capture Capture2

cormacmchale commented 5 years ago

Map page css fixed for a consistant feel Capture

cormacmchale commented 5 years ago

Journey service methods had to be commented and tidied up- this would be much easier done at the time of writing.

cormacmchale commented 5 years ago

Css of homepage now fixed for a nicer UI Capture

cormacmchale commented 5 years ago

Trying to get the login to return the homepage after a successful attempt but not working so far... comments added to this section Capture

cormacmchale commented 5 years ago

Login page now fixed for consistent feel for the whole app Capture

cormacmchale commented 5 years ago

The manage Journeys (database Page) need to have much of the imports and excess removed.. and comments had to be added, again I must remember to just do this at the time of writing the code Before: before After: after

cormacmchale commented 5 years ago

The final two Pages to be commented and finished are the map and Journey planner page

cormacmchale commented 5 years ago

For both of these Pages it was just necessary to remove un-used blocks of code and add comment to all the methods