SignColumn doesn't render like LineNr

cormacrelf / vim-colors-github

A Vim colorscheme based on Github's syntax highlighting as of 2018.

374 stars 43 forks source link

SignColumn doesn't render like LineNr #4

Closed idanko-sv closed 5 years ago

idanko-sv commented 5 years ago

Summary

SignColum part is not rendering properly when the let g:ale_sign_column_always = 1 sets. I couldn't confirm the issue reproducible in another setup.

Reproduced on

Vimr: NVIM 0.3.4
Macvim: VIM - Vi IMproved 8.1 (2018 May 18, compiled Feb 18 2019 23:51:40) macOS version Included patches: 1-950

Expected behavior

SignColum has the same color scheme as LineNr

Actual

SignColum sets to grey

cormacrelf commented 5 years ago

Sounds like... a problem with ale?

idanko-sv commented 5 years ago

@cormacrelf I've changed appropriate lines to:

call s:Col('SignColumn',       'base4',  'gutter')
call s:Col('EndOfBuffer',       'base4',  'gutter')

and the issue gone, but it sounds like controversial approach, and don't wanna PR

idanko-sv commented 5 years ago

@cormacrelf hi, confirm that the issue is reproduced on other themes, however on some of them such as gruvbox, user experience is nicer since SignColumn background has pretty the same color pallet as Normal.