cormorack / yodapy

Your Ocean Data Access in Python
https://cormorack.github.io/yodapy/
MIT License
9 stars 10 forks source link

Don't package the tests folder. #112

Closed ocefpaf closed 5 years ago

ocefpaf commented 5 years ago

Closes #110

lsetiawan commented 5 years ago

This is an awesome PR! Thank you!

lsetiawan commented 5 years ago

This is failing due to 401 Auth Error since PR is coming from outside user.

ocefpaf commented 5 years ago

@lsetiawan the error seems to be unrelated to this PR. Can you take a look? Should we make the UNAUTHORIZED ones as xfail?

PS: are you opened to remove the coding_standards test and adopt black instead?

lsetiawan commented 5 years ago

The UNAUTHORIZED is because the credentials to OOI is setup for this organization only. I'm not familiar with black, but if that's better then I am open to it :) With your help of course hehe

ocefpaf commented 5 years ago

The UNAUTHORIZED is because the credentials to OOI is setup for this organization only.

Then marking then as xfail makes sense to make it easier to review PRs from people outside of the organization.

I'm not familiar with black, but if that's better then I am open to it :) With your help of course hehe

https://black.readthedocs.io/en/stable/

It is a single massive commit, after that one should either set a pre-commit hook it a run a Makefile. The advantage is to never worry about code style again.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 328


Totals Coverage Status
Change from base Build 326: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls