Closed ocefpaf closed 5 years ago
This is an awesome PR! Thank you!
This is failing due to 401 Auth Error since PR is coming from outside user.
@lsetiawan the error seems to be unrelated to this PR. Can you take a look? Should we make the UNAUTHORIZED
ones as xfail
?
PS: are you opened to remove the coding_standards
test and adopt black instead?
The UNAUTHORIZED is because the credentials to OOI is setup for this organization only. I'm not familiar with black, but if that's better then I am open to it :) With your help of course hehe
The UNAUTHORIZED is because the credentials to OOI is setup for this organization only.
Then marking then as xfail
makes sense to make it easier to review PRs from people outside of the organization.
I'm not familiar with black, but if that's better then I am open to it :) With your help of course hehe
https://black.readthedocs.io/en/stable/
It is a single massive commit, after that one should either set a pre-commit hook it a run a Makefile. The advantage is to never worry about code style again.
Closes #110