cormorack / yodapy

Your Ocean Data Access in Python
https://cormorack.github.io/yodapy/
MIT License
9 stars 10 forks source link

Blacken #114

Closed ocefpaf closed 5 years ago

ocefpaf commented 5 years ago

@lsetiawan the second last commit is the massive black changes that hopefully will happen only once.

From now one all people should do is to run the make style before committing code.

lsetiawan commented 5 years ago

COOL! You gotta show me how this works sometime :smile:

ocefpaf commented 5 years ago

COOL! You gotta show me how this works sometime

Next week ;-p

PS: if you create the dev env like in the .travis.yml file you should be able to execute all the commands in the Makefile.

lsetiawan commented 5 years ago

So there's no more coding standard checks with this change?

ocefpaf commented 5 years ago

So there's no more coding standard checks with this change?

Nope. Just ensure people will run "make style" before submitting a PR. You can setup a git hook but I'll leave that for later. (Need to get back to the tutorials ;-p

lsetiawan commented 5 years ago

Failing due to 401. All good here. Thanks!

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 334


Totals Coverage Status
Change from base Build 332: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls