search

cormorack / yodapy

Your Ocean Data Access in Python
https://cormorack.github.io/yodapy/
MIT License
9 stars 10 forks source link

Fix bug in constructing urls on windows #74

Closed lsetiawan closed 6 years ago

lsetiawan commented 6 years ago

Overview

This should fix the Windows bug on creating url to get status of the request.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 193

Totals Coverage Status
Change from base Build 192: 0.0%
Covered Lines:
Relevant Lines: 0
💛 - Coveralls
pshivraj commented 6 years ago

The url change is apparently failing the linux build. I'll keep this open for now.

lsetiawan commented 6 years ago

@pshivraj It has to do something with credentials. I am restarting the job, to make sure it works.

pshivraj commented 6 years ago

@pshivraj It has to do something with credentials. I am restarting the job, to make sure it works.

Yes probably as I was unable to reproduce this error locally for the current PR.

lsetiawan commented 6 years ago

Still failing... sigh...

lsetiawan commented 6 years ago

Runs locally just fine... just travis problem. Will fix soon.