Update the filtering of time for cloud copy

cormorack / yodapy

Your Ocean Data Access in Python

https://cormorack.github.io/yodapy/

MIT License

9 stars 10 forks source link

Update the filtering of time for cloud copy #82

Closed lsetiawan closed 5 years ago

lsetiawan commented 5 years ago

Overview

This PR update the retrieval of data from cloud copy!

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 241

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals
Change from base Build 228:	0.0%
Covered Lines:
Relevant Lines:	0

💛 - Coveralls

lsetiawan commented 5 years ago

@pshivraj Any thoughts on this credential failures?

pshivraj commented 5 years ago

@pshivraj Any thoughts on this credential failures?

I see one failure owing to missing function filter_ncurls() and get_start_end_dates() which apparently looks like has been removed from current pull request. Is there any reason why this module is not needed anymore ?

pshivraj commented 5 years ago

@pshivraj Any thoughts on this credential failures?

I see one failure owing to missing function filter_ncurls() and get_start_end_dates() which apparently looks like has been removed from current pull request. Is there any reason why this module is not needed anymore ?

I tested this locally, since this pull request uses different method to get ncurls so taking away one test case should make this build pass.

lsetiawan commented 5 years ago

I see one failure owing to missing function filter_ncurls() and get_start_end_dates() which apparently looks like has been removed from current pull request. Is there any reason why this module is not needed anymore ?

Yea because we don't need it anymore because the new processed netcdf.

lsetiawan commented 5 years ago

@pshivraj Does this work locally now? If so please merge. Thanks :)

pshivraj commented 5 years ago

Works fine with test case fix. Merging it