cormorack / yodapy

Your Ocean Data Access in Python
https://cormorack.github.io/yodapy/
MIT License
9 stars 10 forks source link

Added random data-sanity check variable definition #89

Closed pshivraj closed 5 years ago

pshivraj commented 5 years ago

Overview

This PR adds programmatic way to check-data sanity doing away with fix date values and rather using random initialization of date variables and look back window.

pshivraj commented 5 years ago

@lsetiawan Can you test this pull request locally ? It seems to work just fine for me but somehow on travis its failing.

lsetiawan commented 5 years ago

I'll try once ooinet is back up.

lsetiawan commented 5 years ago

@pshivraj Everything indeed passed locally!

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 255


Totals Coverage Status
Change from base Build 253: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls
lsetiawan commented 5 years ago

@pshivraj Can we merge this?

pshivraj commented 5 years ago

@pshivraj Can we merge this?

I think we can, it works fine locally for both me and you i suppose ?