sjb017
commented
6 years ago Hello Brian,
Thank you for reporting this issue. I have opened an internal bug report and we will work to get this into our next release.
Scott Breyer Maintainer, intel/opa-ff.
From: Brian Smith [mailto:notifications@github.com] Sent: Thursday, June 14, 2018 1:06 PM To: intel/opa-ff opa-ff@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [intel/opa-ff] Fix bashism in MpiApps/apps scripts. (#14)
Fix #12https://github.com/intel/opa-ff/issues/12 Some scripts in MpiApps/apps shbang /bin/sh but use bash syntax. Change this to bourne shell syntax.
- Use = instead of ==
- Use func() {} instead of function func {}.
You can view, comment on, or merge this pull request online at:
https://github.com/intel/opa-ff/pull/14
Commit Summary
- Fix bashism in MpiApps/apps scripts.
File Changes
- M MpiApps/apps/prepare_runhttps://github.com/intel/opa-ff/pull/14/files#diff-0 (2)
- M MpiApps/apps/run_allhfilatencyhttps://github.com/intel/opa-ff/pull/14/files#diff-1 (4)
- M MpiApps/apps/run_apphttps://github.com/intel/opa-ff/pull/14/files#diff-2 (4)
- M MpiApps/apps/run_cabletesthttps://github.com/intel/opa-ff/pull/14/files#diff-3 (4)
- M MpiApps/apps/run_osuhttps://github.com/intel/opa-ff/pull/14/files#diff-4 (2)
Patch Links:
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/intel/opa-ff/pull/14, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AN7y0m63pb2FkCR0rWwqNxWDbXyhPxsnks5t8pffgaJpZM4UoVFI.
Fix #12 Some scripts in MpiApps/apps shbang /bin/sh but use bash syntax. Change this to bourne shell syntax.