search

cornelisnetworks / opa-ff

Other
11 stars 20 forks source link

IbaTools/stream uses march=native #20

Open bmwiedemann opened 5 years ago

bmwiedemann commented 5 years ago

While working on reproducible builds for openSUSE, I found that IbaTools/stream/Makefile had a -march=native introduced by commit cb934204

This causes packages built on one machine to differ from packages built on another machine with a different CPU. See https://reproducible-builds.org/ for why this matters.

bmwiedemann commented 5 years ago

Submitted a fix to openSUSE: https://build.opensuse.org/request/show/661771

sjb017 commented 5 years ago

Hello, Thank you for the feedback. Does this mean that you will apply your fix for inclusion in the next distribution(s) of SLES? We will work this fix into our process and it will be in our next update. Thank you, Scott Breyer

bmwiedemann commented 5 years ago

I submitted it to Factory which (if accepted) will automatically make it part of SLE16. I will leave the decision about backports to the maintainer: Nicolas Morey-Chaisemartin Maybe they will not be needed, because the breaking commit is so young.

note that -march=native can cause problems for users with older CPUs