search

cornelisnetworks / opa-psm2

Other
37 stars 29 forks source link

Allow to override build date #16

Closed bmwiedemann closed 7 years ago

bmwiedemann commented 7 years ago

in order to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable.

Also uses UTC to be independent of timezone settings.

Note: this invocation works with GNU date, not with BSD date same as https://github.com/01org/psm/pull/16

wojciechwasko commented 7 years ago

Thanks for the pull request. We'll process it internally and get back to you.

aravindksg commented 7 years ago

This commit is now on master. Closing.

bmwiedemann commented 7 years ago

3f30d743ffbd39703e3cecdb25d319ed199d3d97 squashed a lot of changes together and the only hint in the commit message was Include commits from GitHub PR's #13, #14, #16

This is not the way git should be used, e.g. normally people should use git merge or git cherry-pick which preserves the author and commit message text in the repo's history so that others have an easier time to find out why certain things were done, which helps keeping it maintainable.