search

cornelius / inqlude

Command line client for independent Qt library archive
inqlude.org
GNU General Public License v2.0
31 stars 11 forks source link

Add tests for generation of html #48

Closed nanduni-nin closed 7 years ago

nanduni-nin commented 7 years ago

Add tests for extracting data from html files using Nokogiri. The extracted data is stored in a CSV file.

cornelius commented 7 years ago

What is this code supposed to do? It extracts some content to a CSV file, but when is this supposed to run and what is supposed to happen with the written file?

I think it would be more useful to have an integration test, which creates a manifest directory from defined test data, runs inqlude view and then parses the generated HTML files for the expected content and compares that with expectation directly in the test instead of writing out scraped data.