search

cornelius / kode

XML meta programming
http://www.lst.de/~cs/kode
20 stars 10 forks source link

Remove KDE dependency, add qmake projects #13

Closed martonmiklos closed 5 years ago

martonmiklos commented 5 years ago

This PR will remove the KDE dependencies. There is a functionality loss around the kodemain where the creator e-mail address/name needs to be passed as an argument not retrived from the address book.

This PR also adds pro files to be able to build the project with qmake.

It also patches the cmake files to use Qt5. If I remember well we have discussed the Qt4 dropping earlier, but I have not been able to find your answer now. I am under the impression that Qt4 is now far "away", but I would like to hear your opinion. If you do not like dropping Qt4 I can do some research how can cmake handle both versions. (I have seen such a thing in ROS stuff, so it is possible).

cornelius commented 5 years ago

I'm ok with this if @dfaure-kdab also is ok. You two are the main users of kode right now. I'm not using it at the moment. So I'm perfectly happy to leave it to you to do what is required and brings it forward.

@martonmiklos I would be happy to give you push access to the repo so that you are not delayed by me having to look at pull requests. Would you be up for that?

dfaure-kdab commented 5 years ago

I don't mind, I have my own copy of libkode in KDSoap, and I build it with both qmake and cmake.

martonmiklos commented 5 years ago

@cornelius I am ok with having push access to the repo, I will polish my git skills to make less mess than I used to do with the commits ;).

cornelius commented 5 years ago

@martonmiklos ok, I sent you an invite. Have fun :smile: