search

corneliusio / svelte-sublime

💡Sublime Text syntax highlighting for Svelte components
MIT License
58 stars 6 forks source link

Scopes break when binding events to a component #16

Closed ccampbell closed 2 years ago

ccampbell commented 3 years ago

I just started noticing this recently and tested in safe mode in Sublime Text 4. You can see here:

Please let me know if you need any more information. It looks like it starts with the first closing bracket } which is scoped as invalid.illegal.stray-bracket-end.js

I am happy to take a look at fixing it myself too, but figured I would open up an issue here since you may know exactly what the issue is. Thanks!

easyfrog commented 2 years ago

I have same issue, could you tell me how you fix it?

ilokhov commented 2 years ago

Seeing the same issue, specifically after updating Sublime Text to Build 4121. The change to cause this might have happened in dev Build 4114 which mentions "Various syntax highlighting improvements" in the changelog.

ccampbell commented 2 years ago

I actually have a fix for this. Will try to clean it up and send a PR later today.

wmstens commented 2 years ago

It sounds like the original dev is busy. Do you have the fix ironed out @ccampbell? Sorry to bug.

ccampbell commented 2 years ago

@wmstens just opened a pull request. Feel free to try out my fork. #18

wmstens commented 2 years ago

I just sideloaded this fork and it seems to work for me. Thanks a bunch!

corneliusio commented 2 years ago

Noting here, I've started working on some fixes that are in the https://github.com/corneliusio/svelte-sublime/tree/v4 branch. There are still some issues, but it's far less broken than the current release. Feel free to manually install while I finish up some of the smaller fixes.

I'm also going to lock convo on this issue in favor of #17 to tidy things up a bit, will leave this open till resolved though for reference.

corneliusio commented 2 years ago

Should now be fixed with v3.5.0.