search

corneliusio / svelte-sublime

💡Sublime Text syntax highlighting for Svelte components
MIT License
59 stars 6 forks source link

Add new patch for PascalCased tags that can be self-closing. #22

Closed ehzro3 closed 2 years ago

ehzro3 commented 2 years ago

I tried to address the issue I've opened. This is my first attempt to make a contribution in GitHub, so please let me know for any mistake I'm making.

corneliusio commented 2 years ago

Wanted to say thanks for the PR! There were some things I needed to do differently to accomplish this so I ended up doing the change myself.

ehzro3 commented 2 years ago

Thank you! I’m happy it’s implemented in a more concise way. I will learn Sublime more in the future so I can make contribution in the context.

corneliusio commented 2 years ago

@ehzro3 It's much appreciated. It would prob be good if I added a contribution guide to the repo. But the issue was really just that changes to the syntax definitions need to be made in Svelte.sublime-syntax.yaml-macros and then built with the YAML Macros Sublime package. Never hesitate to make PRs though! It's one of the best ways to get more familiar with a specific platform.