A minimal change to make working emulated Hub with PoweredUp on Android

corneliusmunz / legoino

Arduino Library for controlling Powered UP and Boost controllers

MIT License

261 stars 34 forks source link

A minimal change to make working emulated Hub with PoweredUp on Android #40

Closed wmarkow closed 3 years ago

wmarkow commented 3 years ago

This is a proposed fix for issue #27.

PoweredUp should work without restartin (or clearing its cache), so there is some improvement here. I have noticed that sometimes I need to restart bluetooth to make it working (especially when I flashed a new and modified software to ESP32).

My test devices:

Samsung Galaxy J3 (2016) with Android 5.1.1 and PoweredUp 3.5.0
Huawei SNE-LX1 with Android 10 and PoweredUp 3.5.0

Please retest.

corneliusmunz commented 3 years ago

@wmarkow Thank you very much for your PR and your contribution to the library! Very good findings. I will check it with my iOS devices if these are still working without any issues and then i can merge your PR.

corneliusmunz commented 3 years ago

Builds are successful on different boards (Github actions)
Tested on Samsung Galaxy A41, Android 10, PoweredUp App v 3.5.0 and 3.6.0
Tested on iPhone 11 Pro, iOS 14.2, PoweredUp App v3.6.0
Tested on Samsung Galaxy S5 mini, Android 6.0.1, PoweredUp app 3.1.1, PoweredUp app 3.6.0

wmarkow commented 3 years ago

I'm also happy that it works.