search

corneliusmunz / legoino

Arduino Library for controlling Powered UP and Boost controllers
MIT License
257 stars 34 forks source link

Please use scoped enums throughout Lpf2HubConst.h #49

Open StefansProjects opened 3 years ago

StefansProjects commented 3 years ago

Perhaps you could use scoped enums throughout Lpf2HubConst.h. Especially the Color enum (values) colides with other similar definitions and scoped enums would help to keep the code interoperable with other libraries.

corneliusmunz commented 3 years ago

Hi @StefansProjects Thanks for reporting that issue. I have done it for other enums but i have missed that in the "breaking" change from 0.x.x to 1.0.0 Now if i will change it it will be another breaking change. But i will do it if the next "big" change will occur