search

corneliusroemer / pango-designation-dates

Contains dates on which each Pango lineage was designated
5 stars 2 forks source link

Malformed lineage designations #2

Closed ciscorucinski closed 1 year ago

ciscorucinski commented 1 year ago

Line 2605 - 2607 have the wrong designation code assigned to them.

lineage designation_date
XBC.XAY.2.1 2023-02-11
XBC.XAY.2.2 2023-02-11
XBC.XAY.1 2023-02-11

It is possible that these 3 can be deleted. There are 2 apparent duplicates below these malformed entries, and the last malformed one doesn't appear to be correctable.

Additional context
https://github.com/cov-lineages/pango-designation/commit/1dcf0fe12f35f73feba7c529d365c9f721928dd8

Screenshot from 2023-02-11 16-18-50

corneliusroemer commented 1 year ago

This has been fixed in a later commit - I mistyped along the way ;)

ciscorucinski commented 1 year ago

The malformed lineages are still present in main. Shouldn't they be removed? It looks like both the malformed and corrected lineages were both pushed at the same time https://github.com/corneliusroemer/pango-designation-dates/commit/41f39797e588c38a722ed2f7d20b62bef603f3d6

corneliusroemer commented 1 year ago

Aaah, I get it! It's fixed in the main designations but not in the designation dates. Sorry!