search

corneliusweig / rakkess

Review Access - kubectl plugin to show an access matrix for k8s server resources
Apache License 2.0
1.3k stars 56 forks source link

Refactor util package #18

Closed corneliusweig closed 5 years ago

corneliusweig commented 5 years ago

util is a horrible package name, because it could be anything. The package contained validation and printing utils, so the utils were split up into two new packages printer and validation.

codecov-io commented 5 years ago

Codecov Report

Merging #18 into master will decrease coverage by 0.91%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   72.64%   71.72%   -0.92%     
==========================================
  Files          12       11       -1     
  Lines         468      474       +6     
==========================================
  Hits          340      340              
- Misses        115      121       +6     
  Partials       13       13
Impacted Files Coverage Δ
pkg/rakkess/printer/terminal_notwindows.go 60% <ø> (ø)
pkg/rakkess/printer/consuming_tabwriter.go 92.64% <ø> (ø)
pkg/rakkess/printer/printer.go 90.9% <ø> (ø)
pkg/rakkess/validation/validation.go 66.66% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3a3825d...2da129f. Read the comment docs.