search

corneliusweig / rakkess

Review Access - kubectl plugin to show an access matrix for k8s server resources
Apache License 2.0
1.3k stars 56 forks source link

Strip custom throttling #75

Closed corneliusweig closed 4 years ago

corneliusweig commented 4 years ago

The API client always restricts the QPS. Rakkess' resource client abstraction had an additional throttle to prevent more than 20 concurrent requests. This is now removed in favor of the builtin throttling mechanism.

This should help with #58

codecov-commenter commented 4 years ago

Codecov Report

Merging #75 into master will increase coverage by 0.44%. The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   74.02%   74.46%   +0.44%     
==========================================
  Files          15       15              
  Lines         485      470      -15     
==========================================
- Hits          359      350       -9     
+ Misses        102       98       -4     
+ Partials       24       22       -2
Impacted Files Coverage Δ
internal/client/result/resource.go 100.00% <ø> (ø)
internal/client/resource_access.go 91.83% <90.47%> (+7.96%) :arrow_up:
internal/client/result/subject.go 92.30% <100.00%> (-0.20%) :arrow_down:
internal/printer/printer.go 89.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1116e5f...90fc2b3. Read the comment docs.