search

cornell-brg / pymtl

Python-based hardware modeling framework
BSD 3-Clause "New" or "Revised" License
237 stars 82 forks source link

Ctorng fixes #146

Closed ctorng closed 8 years ago

ctorng commented 8 years ago

My commit messages both have "see mores" with details. My main other concern here though might be performance for the hashing method.

Derek used hash() on a frozenset of the arguments for performance reasons:

Or at least that is the feeling I got from reading that stackoverflow link. I put class into the frozenset in order to properly differentiate the two Mux's I had problems with. The class string includes the hierarchy to get to the module, so I thought it was the smallest thing I could add to create the differentiation. But I'm not sure if calling class is actually expensive or anything...

Chris

cbatten commented 8 years ago

I think we should we go ahead and merge this into the ece4750 branch then?