Lt fix a lot of small things and remove sendkv

cornell-cup / cs-minibot

[WIP] Software platform for MiniBot, an educational robotics kit made for Da Vinci Labs.

http://cornellcuprobotics.com/projects.html#minibot

Apache License 2.0

5 stars 1 forks source link

Lt fix a lot of small things and remove sendkv #77

Closed leotrj closed 7 years ago

leotrj commented 7 years ago

Looks like this now.

Fixes:

removed redundant print statement from gridview
Added missing sensor methods in bot (also other missing parts)
Finds script and displays it in a dropdown
SendKV is now g o n e

Tested:

Works, HOWEVER, once you run script, the bot can't move anymore. Which is already an existing problem and is currently being worked on .

anmolkabra commented 7 years ago

Did you remove the sendKV function altogether or just don't use it in the GUI? If it's the former, I'll want to check the basestation impl and see that there are no dangling sendKV usages. Will do that by wed night. Nice job - I like that we don't want the user to deal with sendKV.

anmolkabra commented 7 years ago

Did someone attend to my previous sendKV comment already? I was going to review the PR to check for dangling sendKV dependencies but this PR has been already merged 😢

chynu commented 7 years ago

@anmolkabra SendKV is still in tact in the back-end. We aren't removing the back-end code for sendkv, we're just changing the front-end so that our end users don't have to worry about typing in "RUN" and a script name.

It's more of a front-end pull request than anything that touches back-end (in the end it's doing the same thing -- we haven't changed any functionality).