search

cornell-dti / idol

Internal tools platform for DTI, a project team/web development club at Cornell University, which automates all operations of an organization of 100+ members.
GNU Affero General Public License v3.0
7 stars 2 forks source link

Website: Fix Linkedin Links and Add Falsy Check for Links #726

Closed andrew032011 closed 1 week ago

andrew032011 commented 1 week ago

Summary

Noticed that there's a number of profiles in Alumni page that don't have Linkedin's or have malformed URL's. I fixed the malformed URL's and add all the missing links.

Also fixed how we handle empty links. Right now, a link of "" would lead to a redirect back to the current page (instead of a no-op).

Notion/Figma Link

https://www.notion.so/Website-Fix-Linkedin-Links-and-Fix-Check-for-Empty-Links-1450ad723ce1801a8058eeeaa05ebfd3?pvs=4

Test Plan

Manually click through all links on alumni page, and observe that it redirects to their LinkedIn profiles.

Notes

Breaking Changes

dti-github-bot commented 1 week ago

[diff-counting] Significant lines: 2.