Website Redesign: Banner component

cornell-dti / idol

Internal tools platform for DTI, a project team/web development club at Cornell University, which automates all operations of an organization of 100+ members.

GNU Affero General Public License v3.0

7 stars 2 forks source link

Website Redesign: Banner component #727

Closed JasonMun7 closed 1 week ago

JasonMun7 commented 1 week ago

Summary

Created a reusable Full Width Banner component with the three variants from the figma below (We can add more variants in the future or change this as necessary). I also added disabled buttons instead of omitting them when the application is not open to keep it consistent.

Notion/Figma Link

https://www.figma.com/design/ttAGEX3pHmzuhMzp8uAyhz/DTI-New-Landing-Website?node-id=7-45&node-type=canvas

https://github.com/user-attachments/assets/66be0777-0ae9-49e5-bbe9-f59771b22906

dti-github-bot commented 1 week ago

[diff-counting] Significant lines: 75.

JasonMun7 commented 1 week ago

Nice! Just a lil change for the button's hover effect, and a little check on mobile.

Bonus: could you provide screenshots of the other 2 variants on your PR description just for documentation purposes? Even if we're not using them right now, I think it'd still be helpful to preserve a snapshot of them.

These are the other two variants that were just on the figma. I just added this because it was on the figma but this was just to make it more reusable for the future!

Bookie0 commented 1 week ago

These are the other two variants that were just on the figma. I just added this because it was on the figma but this was just to make it more reusable for the future!

OK awesome thanks for adding! Feel free to re-request my review when u fix the btn thing