search

cornell-dti / idol

Internal tools platform for DTI, a project team/web development club at Cornell University, which automates all operations of an organization of 100+ members.
GNU Affero General Public License v3.0
7 stars 2 forks source link

Pull from IDOL Images: Compress Images to < 300 KB #739

Closed andrew032011 closed 4 days ago

andrew032011 commented 5 days ago

Summary

We previously didn't have any image compression logic, which required us to manually compress images when they exceed the limit.

Make the Pull from IDOL Images script compress images to < 300 KB. We can also revisit this if it makes the images too low quality/blurry.

We may consider overwriting the bucket's images with the compressed version, but only if we verify that the quality is not significantly diminished. For now, we should keep the images in the bucket as a source of truth for what the original image looked like.

Notion/Figma Link

https://www.notion.so/Website-Compress-Images-in-Pull-from-IDOL-Images-Job-1410ad723ce18056a2f1f224afae14d1?pvs=4

Test Plan

Pull from IDOL Images PR: https://github.com/cornell-dti/idol/pull/729

Notes

Breaking Changes

dti-github-bot commented 5 days ago

[diff-counting] Significant lines: 38.