cornell-dti / idol

Internal tools platform for DTI, a project team/web development club at Cornell University, which automates all operations of an organization of 100+ members.
GNU Affero General Public License v3.0
7 stars 2 forks source link

New Website: Home Page, Hero Section, and Footer Improvements #741

Closed andrew032011 closed 4 days ago

andrew032011 commented 4 days ago

Summary

Resolves 4 tickets:

Notion/Figma Link

Test Plan

Hero section revamp: Remove italic font style, make subheader (eg: “Working together” or “Real impact”) primary (white) color, make body text secondary (white + 70% transparent) color

Screenshot 2024-11-28 at 2 58 22 PM Screenshot 2024-11-28 at 2 58 19 PM Screenshot 2024-11-28 at 2 58 16 PM Screenshot 2024-11-28 at 2 58 12 PM Screenshot 2024-11-28 at 2 58 09 PM Screenshot 2024-11-28 at 2 58 07 PM

Use dimmer color for text and icons for the footer

Before:

Screenshot 2024-11-28 at 2 59 14 PM

After:

Screenshot 2024-11-28 at 2 58 51 PM

Use same font size for monospaced font in thumbnail image (16px for both, 8px in mobile view) Change hero section header to "Building the Future of Tech @ Cornell"

Desktop: Before:

Screenshot 2024-11-28 at 2 59 58 PM

After:

Screenshot 2024-11-28 at 2 59 52 PM

Mobile: Before:

Screenshot 2024-11-28 at 3 00 05 PM

After:

Screenshot 2024-11-28 at 3 00 11 PM

Notes

I created two new variables for the hero section heroPrimary and heroSecondary, @cchrischen @JasonMun7 @Bookie0 please let me know if that's not the most idiomatic way to do this.

Breaking Changes

dti-github-bot commented 4 days ago

[diff-counting] Significant lines: 116.

cchrischen commented 4 days ago

Some of the pages' footers don't match the Figma designs, particularly whether they are light or dark on the initiatives and sponsor page. This was something that I forgot to include during initial development, and since you changed up the footer, can we add it in here? Curious to see if we just want to stick with the dynamic footer or have it only be in black. The light version can be seen on the team page.

andrew032011 commented 4 days ago

Some of the pages' footers don't match the Figma designs, particularly whether they are light or dark on the initiatives and sponsor page. This was something that I forgot to include during initial development, and since you changed up the footer, can we add it in here? Curious to see if we just want to stick with the dynamic footer or have it only be in black. The light version can be seen on the team page.

I'm down to change it! @Bookie0 do you have thoughts here? Keep the footer consistent to the page theme? Or just dark all around?