Website: Sponsor Page Improvements - Githubissues

cornell-dti / idol

Internal tools platform for DTI, a project team/web development club at Cornell University, which automates all operations of an organization of 100+ members.

GNU Affero General Public License v3.0

7 stars 2 forks source link

Website: Sponsor Page Improvements #747

Closed cchrischen closed 4 days ago

cchrischen commented 4 days ago

Summary

This PR addresses comments made about the sponsor page in the recent audit of the website.

Changed the three features in a row to match the styling found on the course page.
Fixed the "Become a Sponsor" section
- increased vertical padding
- increased image size
- use more consistent header styling (took from "introducing the team" on the team page)
- fixed text hierarchy

Notion/Figma Link

3 features in a row section fix "Become a sponsor!" section fixes

Test Plan

3 features before: 3 features after:

Become a Sponsor before: Become a Sponsor after, same viewport:

Notes

Breaking Changes

Database schema change (anything that changes Firestore collection structure)
Other change that could cause problems (Detailed in notes)

dti-github-bot commented 4 days ago

[diff-counting] Significant lines: 51.

andrew032011 commented 4 days ago

LGTM but maybe @Bookie0 can take a quick peek.