search

cornell-dti / nova.cornelldti.org

The new website.
https://www.cornelldti.org/
GNU Affero General Public License v3.0
3 stars 1 forks source link

[RFC] Get rid of netlify CMS #350

Closed SamChou19815 closed 3 years ago

SamChou19815 commented 3 years ago

Summary

Looking at the recent commits, the last time we ever use the CMS to trigger the repo update is Nov. 25 in this PR. Recently, it appears to me that we are just using the github web interfaces to update json.

I admire the engineering effort put into to setup the CMS. However, due to its low usage, it's the time to seriously consider whether it's worth keeping it. Currently, the CMS is causing several issues:

  1. Eventually, the IDOL backend will become the source of truth for members json and its frontend will be the place to update info. Having two parallel apps can be tricky.
  2. To support preview for netlify CMS, we have to build the vue component twice. This results in extremely long build times.
  3. More sources of indirection inside the source code, which is not very friendly to newbies who want to help maintain this repo.

Therefore, IMO, it's time for the CMS to be gone. In this PR, I removed all the supporting code for netlify CMS, and inlined the json into respective view components to avoid more indirection.

Test Plan

Check every page in the preview site still works.

Notes

Compared to the last commit on master, we improve the build time from 5min to 4min.

dti-github-bot commented 3 years ago

[diff-counting] Significant lines: 256.

dti-github-bot commented 3 years ago

[deployment-bot] Deployed to https://60302a4050dc58256e750ff7--cornelldti-old.netlify.app.

ewlsh commented 3 years ago

While I'm here...

I am beyond ecstatic that IDOL is happening. Netlify CMS was a bad compromise that I agree was a feat but didn't turn out particularly well.

I proposed a "hub" style product in my DTI interview and pitched a DTI data hub later on, so I :heart: IDOL and wish y'all the best :rainbow: