Closed hanchenye closed 2 years ago
Thanks @hanchenye for updating the APIs. It is such a huge project that requires lots of engineering effort!
Since LLVM 15.0.0 will be released on July 26 according to their schedule, we'll also upgrade to it next week. If your changes are compatible with LLVM 15, I will merge them into our branch.
Great to know! Most of the changes should be reusable for 15.0.0 :P
Have updated this patch to 15.0.0-rc, all tests passed.
Thanks @hanchenye! Can you also update the CI file? https://github.com/cornell-zhang/hcl-dialect-prototype/blob/main/.circleci/config.yml#L19 https://github.com/cornell-zhang/hcl-dialect-prototype/blob/main/.circleci/config.yml#L26 https://github.com/cornell-zhang/hcl-dialect-prototype/blob/main/.circleci/config.yml#L41
Have rebased to the upstream main and updated the CI.
CI test failed. We probably need to upgrade the cmake version.
CMake Error at /home/circleci/hcl-dialect-prototype/llvm-project/mlir/cmake/modules/MLIRDetectPythonEnv.cmake:6 (message):
Building MLIR Python bindings is known to rely on CMake features that
require at least version 3.19. Recommend upgrading to 3.19+ for full
support. Detected current version: 3.16.3
Call Stack (most recent call first):
/home/circleci/hcl-dialect-prototype/llvm-project/mlir/CMakeLists.txt:143 (mlir_configure_python_dev_packages)
CI test failed. We probably need to upgrade the cmake version.
Auh right, I updated my local cmake version to make it work. I think it's part of the CI here? https://github.com/cornell-zhang/hcl-dialect-prototype/blob/d0fa530f1c6eef84bd8df98ffc27f29fece9cfb8/.circleci/config.yml#L17
The new version is not updated to ubuntu sources yet I believe. So we may need to manually fetch the new version in the CI...
Yes, you can try something like
wget https://github.com/Kitware/CMake/releases/download/v3.23.3/cmake-3.23.3.tar.gz
tar -xzvf cmake-3.23.3.tar.gz
cd cmake-3.23.3
./bootstrap
make
make install
CI passed! 😃
Cool! Thanks for your great effort!!!
In order to leverage the new Transform dialect, I have to bump the version of LLVM. Have fixed numerous issues caused by API changes from 14.0.0 to present... Passes all regression tests and works on my own driving example as well.
If we don't have a plan to update the LLVM version until 15.0.0, this branch could be used as a playground on testing new MLIR/LLVM features, etc.