cornell-zhang / hcl-dialect

HeteroCL-MLIR dialect for accelerator design
https://cornell-zhang.github.io/heterocl/index.html
Other
37 stars 15 forks source link

[Backend] Remove compulsory const type prefix in HLS #205

Closed chhzh123 closed 10 months ago

chhzh123 commented 10 months ago

As the title reads, this PR removes compulsory "const" generation for global tensors. It will check whether the op has a "const" attribute to determine whether to generate a prefix. Basically, it will cause an error when we have multiple functions, and the constant tensors are passed through some function arguments, where we do not update the function signatures, causing the error.