Closed hecmay closed 4 years ago
It makes no sense to ignore the source and header files. Maybe Yang was trying to ignore some other cpp files? Not sure.
On Nov 28, 2019, at 9:16 AM, Yi-Hsiang (Sean) Lai notifications@github.com wrote:
@seanlatias commented on this pull request.
In .gitignore https://github.com/cornell-zhang/heterocl/pull/138#discussion_r351803054:
@@ -16,8 +16,8 @@ tags docs/source/samples docs/source/tutorials soda_ -.cpp -.h +# .cpp +# *.h Why?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cornell-zhang/heterocl/pull/138?email_source=notifications&email_token=AG5DE4CUVACXSXJJHE65MEDQV7HFXA5CNFSM4JSUYKK2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCNKKJ5I#pullrequestreview-324314357, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG5DE4BROMFA4H7EBUMGWMDQV7HFXANCNFSM4JSUYKKQ.
Please also try to fix the tests. For the interface, please make it compatible with the old interface first. Then we can say in the next version we will disable them.
s.to()
primitives)