Closed Huyuwei closed 6 years ago
Could you modify the samples to demonstrate the usability in practice, and add unit tests?
I feel like reorder should work similar to np.transpose or tf.transpose and take a list of integers. Is that possible?
On Tue, Jul 17, 2018, 3:51 PM Cody Hao Yu notifications@github.com wrote:
Could you modify the samples to demonstrate the usability in practice, and add unit tests?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cornell-zhang/heterocl/pull/21#issuecomment-405753393, or mute the thread https://github.com/notifications/unsubscribe-auth/AGYd0Nru7R2htCWUnjO-ysW9CI7Ogm0xks5uHmpcgaJpZM4VTrR9 .
I agree with @comaniac . It's very important for us to create unit tests for each new feature we add as well as each bug fix.
We do have a unit test for this.
https://github.com/cornell-zhang/heterocl/blob/master/heterocl/tests/test_schedule.py
Nonetheless, we will make it more complete in the future.
It is similar to transpose. It's a good idea to directly take in a list of integers.
This PR adds reorder schedule. Now we can write code:
The generated IR is: