search

cornell-zhang / heterocl

HeteroCL: A Multi-Paradigm Programming Infrastructure for Software-Defined Heterogeneous Computing
https://cornell-zhang.github.io/heterocl/
Apache License 2.0
322 stars 92 forks source link

[API] Fix out-of-date HLS reports #247

Closed chhzh123 closed 4 years ago

chhzh123 commented 4 years ago

This PR fixes #246 that HeteroCL outputs out-of-date HLS reports when the program is synthesized several times. By enforcing HeteroCL to regenerate json output, the retrieved HLS report will be up-to-date.

chhzh123 commented 4 years ago

The HLS report API is changed back to f.report(). No need to pass in target and mode, since they have been defined when calling hcl.build. The target will be attached to the generated module now.

chhzh123 commented 4 years ago

@seanlatias Could you help review and merge this PR? No new features are introduced. Just a fix.

chhzh123 commented 4 years ago

@Hecmay My CI tests also failed in test_keras.py. It seems the incorrect Keras version makes all the things crashed.

hecmay commented 4 years ago

LGTM.

@seanlatias @zhangzhiru Do you have any comments on the naming? The extracted HLS report is now saved as profile.json. I think report.json sounds better.

chhzh123 commented 4 years ago

Yes, the HLS reporting feature was added before the profiler, so I did not care so much about the naming at that time. I have changed it to report.json.