Partition pragma on the same array

chhzh123 commented 4 years ago

It's unable to partition the same array along different dimensions.

def conv2():
    A = hcl.placeholder((6, 6), "A")
    F = hcl.placeholder((3, 3), "F")

    def kernel(A, F):
        r = hcl.reduce_axis(0, 3)
        c = hcl.reduce_axis(0, 3)
        return hcl.compute((4, 4),
                lambda y, x: hcl.sum(A[y+r, x+c] * F[r, c], axis=[r, c]), "B")

    s = hcl.create_schedule([A, F], kernel)
    LB = s.reuse_at(A, s[kernel.B], kernel.B.axis[0], "LB")
    WB = s.reuse_at(LB, s[kernel.B], kernel.B.axis[1], "WB")
    s.partition(F, hcl.Partition.Cyclic, factor=3, dim=2)
    s.partition(F, hcl.Partition.Cyclic, factor=3, dim=1) # different dimensions
    s[kernel.B].pipeline(kernel.B.axis[1])

    target = hcl.platform.zc706
    target.config(compile="vivado_hls",mode="csyn")
    f = hcl.build(s, target=target)
    hcl_A = hcl.asarray(np.random.randint(0, 10, A.shape))
    hcl_F = hcl.asarray(np.random.randint(0, 10, F.shape))
    hcl_B = hcl.asarray(np.zeros((4, 4)))
    f(hcl_A, hcl_F, hcl_B)

Got the following error.

heterocl.tvm._ffi.base.TVMError: [13:00:46] src/schedule/schedule_reorder.cc:420: Check failed: !subgraph_op_names.count(name) F.partitioned

If I change the partition commands to

F_ = s.partition(F, hcl.Partition.Cyclic, factor=3, dim=2)
s.partition(F_, hcl.Partition.Cyclic, factor=3, dim=1) # different dimensions

I obtain a wrong piece of code.

void test(bit32 A[6][6], bit32 F[3][3], bit32 B[4][4])
    bit32 F_partitioned;
    #pragma HLS array_partition variable=F_partitioned cyclic dim=1 factor=3
    bit32 F_partitioned_partitioned;
    #pragma HLS array_partition variable=F cyclic dim=2 factor=3

hecmay commented 4 years ago

The first check means that we do not allow two stages to have the same name. If you can rename the second partition with a unique name, it should pass the first check.

chhzh123 commented 4 years ago

The first check means that we do not allow two stages to have the same name. If you can rename the second partition with a unique name, it should pass the first check.

I think in this case we only have one stage named B? And we do not provide APIs to name the partitions.