Closed yn224 closed 3 years ago
It seems that the CI container is container circleci/python:3.6
. And you can change it to 3.7 to fix the error.
It seems that the CI container is
container circleci/python:3.6
. And you can change it to 3.7 to fix the error.
I'm confused. Why do we need to change CI env? It seems the error is because the test is terminated.
Or more precisely, the test is canceled.
Make sure you merge or rebase the upstream. The CI Python env version is changed here. If the CI env needs to be changed, please file a PR instead.
Or more precisely, the test is canceled.
The previous CI test failed with an error complaining that python 3.7 is required by not found.
I was trying to rerun the CI to pinpoint why. But I suddenly found the issue. So I cancelled it.
@yn224 can you change the comment format according to here?
Please update this file to include required packages. Also please do the following two things:
@seanlatias I'm not too sure about these TVM errors that are getting raised
We don't have vivado_hls
on CI. That's why I suggested you directly test on an existing report file instead of generating one.
@yn224 Please let me know if you're ready for review.
@seanlatias I think it can be reviewed now.
This is just the first round. Please fix these first and I'll do a second round.
@seanlatias I believe all of your comments are resolved. Further idea I have about testing includes querying with invalid column names and loop names. But they currently seem to raise IndexError
, which I still need to investigate more.
Great, I'll take a look.
This PR attempts to improve upon the HLS report interface display, specifically targeting the latency information it returns.
Proposed interface:
Here,
loops
represent an array of loop names,levels
represent the maximum loop nest levels the report should print, andcols
represent an array of latency category names.An example output
The current report interface only includes information about resource usage of the HLS simulation. In order to get more information regarding the HLS report (such as latency values), one has to traverse down the chain of directories created by the simulation, which can be cumbersome. However, by adding this new class
rptdisp
in this PR, we can also display latency information in addition to the default report that gets generated currently.Possible limitations The proposed report interface enhancement does not support programs without any loops. Also, querying via regular expressions is unavailable as of now.